From 6094b6f49c4f6ff519eb1469dbba871cfdf2d5bb Mon Sep 17 00:00:00 2001 From: Haylan Date: Thu, 17 Sep 2026 12:39:08 +0200 Subject: [PATCH] test(dump): replace @dataProvider annotations with #[DataProvider] attributes The installed PHPUnit (12.x, ahead of this plugin's ^10.0 dev constraint) no longer parses the @dataProvider PHPDoc annotation, so both tests silently ran their data-provider method with zero arguments and failed with ArgumentCountError. Co-Authored-By: Claude Sonnet 5 --- tests/Service/DumpFilenameParserTest.php | 5 ++--- tests/Service/MySqlVariantTest.php | 5 ++--- 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/tests/Service/DumpFilenameParserTest.php b/tests/Service/DumpFilenameParserTest.php index 354b1e5..5b043fc 100644 --- a/tests/Service/DumpFilenameParserTest.php +++ b/tests/Service/DumpFilenameParserTest.php @@ -3,6 +3,7 @@ namespace AeonDumpManager\Tests\Service; use AeonDumpManager\Service\DumpFilenameParser; +use PHPUnit\Framework\Attributes\DataProvider; use PHPUnit\Framework\TestCase; class DumpFilenameParserTest extends TestCase @@ -29,9 +30,7 @@ class DumpFilenameParserTest extends TestCase self::assertEquals($dateTime, $this->parser->parse($filename)); } - /** - * @dataProvider invalidFilenameProvider - */ + #[DataProvider('invalidFilenameProvider')] public function testParseRejectsInvalidFilenames(string $filename): void { self::assertNull($this->parser->parse($filename)); diff --git a/tests/Service/MySqlVariantTest.php b/tests/Service/MySqlVariantTest.php index fb6020c..8947726 100644 --- a/tests/Service/MySqlVariantTest.php +++ b/tests/Service/MySqlVariantTest.php @@ -3,13 +3,12 @@ namespace AeonDumpManager\Tests\Service; use AeonDumpManager\Service\MySqlVariant; +use PHPUnit\Framework\Attributes\DataProvider; use PHPUnit\Framework\TestCase; class MySqlVariantTest extends TestCase { - /** - * @dataProvider versionProvider - */ + #[DataProvider('versionProvider')] public function testIsMariaDb(string $version, bool $expected): void { self::assertSame($expected, MySqlVariant::isMariaDb($version));