From 5c47888a49a3e9550741b1179b7db68a85339ece Mon Sep 17 00:00:00 2001 From: Haylan Date: Tue, 7 Jul 2026 13:31:52 +0200 Subject: [PATCH] test(github): exercise startFetch()/resolveFetch() instead of fetch() --- tests/Unit/Service/Provider/GitHubProviderTest.php | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/tests/Unit/Service/Provider/GitHubProviderTest.php b/tests/Unit/Service/Provider/GitHubProviderTest.php index 1e8b9f4..0307a12 100644 --- a/tests/Unit/Service/Provider/GitHubProviderTest.php +++ b/tests/Unit/Service/Provider/GitHubProviderTest.php @@ -96,7 +96,8 @@ final class GitHubProviderTest extends TestCase ]], ])); - $result = $this->makeProvider(client: $client)->fetch(); + $provider = $this->makeProvider(client: $client); + $result = $provider->resolveFetch($provider->startFetch()); $this->assertSame(4, $result['2024-06-10']); $this->assertSame(2, $result['2024-06-11']); @@ -112,7 +113,8 @@ final class GitHubProviderTest extends TestCase ]], ])); - $result = $this->makeProvider(client: $client)->fetch(); + $provider = $this->makeProvider(client: $client); + $result = $provider->resolveFetch($provider->startFetch()); $this->assertArrayNotHasKey('2024-06-11', $result); } @@ -130,7 +132,8 @@ final class GitHubProviderTest extends TestCase $this->expectException(ServiceUnavailableHttpException::class); - $this->makeProvider(client: $client)->fetch(); + $provider = $this->makeProvider(client: $client); + $provider->resolveFetch($provider->startFetch()); } #[Test] @@ -139,7 +142,8 @@ final class GitHubProviderTest extends TestCase $client = $this->createStub(HttpClientInterface::class); $client->method('request')->willReturn($this->stubGraphqlResponse([])); - $result = $this->makeProvider(client: $client)->fetch(); + $provider = $this->makeProvider(client: $client); + $result = $provider->resolveFetch($provider->startFetch()); $this->assertSame([], $result); }