haylan/git-contribution-graph
1
0
Fork 0
Code Issues 2 Pull Requests 1 Actions Packages Projects Releases 3 Wiki Activity

fix(entity): re-index ContributionCollection constructor arguments

Browse Source 
array_map() over the variadic constructor can produce non-sequential or
string keys, which doesn't match the array<int, Contribution> property
type; re-index with array_values(). Also documents the iterator/count
accessors.
This commit is contained in:
haylan
2026-07-12 23:43:01 +02:00
parent 14ea788522
commit 8e349c961b
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/Entity/ContributionCollection.php
+3 -1
View File
@@ -14,14 +14,16 @@ final class ContributionCollection implements \IteratorAggregate, \Countable
public function __construct(Contribution ...$contributions) public function __construct(Contribution ...$contributions)
{ {
$this->contributions = $contributions; $this->contributions = array_values($contributions);
} }
/** @return \ArrayIterator<int, Contribution> */
public function getIterator(): \ArrayIterator public function getIterator(): \ArrayIterator
{ {
return new \ArrayIterator($this->contributions); return new \ArrayIterator($this->contributions);
} }
/** Number of contributions held in this collection. */
public function count(): int public function count(): int
{ {
return count($this->contributions); return count($this->contributions);